package sequencer_table

  1. Overview
  2. Docs

Source file sequencer_table.ml

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
open! Core
open! Async
open! Import

let debug_on_find_state = ref ignore

module Make (Key : Hashable) = struct
  module Tag = struct
    type 'job_tag t =
      | User_job of 'job_tag option
      | Prior_jobs_done
    [@@deriving sexp]
  end

  module Job = struct
    type ('state, 'job_tag) t =
      { tag : 'job_tag Tag.t
      ; run : ('state option -> unit Deferred.t) 
      }

    let sexp_of_t _ sexp_of_job_tag t = t.tag |> [%sexp_of: job_tag Tag.t]
  end

  type ('state, 'job_tag) t =
    { states : 'state Key.Table.t
    (* We use a [Queue.t] and implement the [Throttle.Sequencer] functionality ourselves,
       because throttles don't provide a way to get notified when they are empty, and we
       need to remove the table entry for an emptied throttle. *)
    ; jobs   : ('state, 'job_tag) Job.t Queue.t Key.Table.t
    }
  [@@deriving sexp_of, fields]

  let create () =
    { states = Key.Table.create ()
    ; jobs   = Key.Table.create ()
    }
  ;;

  let rec run_jobs_until_none_remain t ~key (queue : (_, _) Job.t Queue.t) =
    match Queue.peek queue with
    | None -> Hashtbl.remove t.jobs key
    | Some job ->
      (* The state of [key] is found and fed to [job] immediately; there should be no
         deferred in between. *)
      let state = Hashtbl.find t.states key in
      !debug_on_find_state ();
      job.run state >>> fun () ->
      assert (phys_equal (Queue.dequeue_exn queue) job);
      run_jobs_until_none_remain t ~key queue;
  ;;

  let set_state t ~key = function
    | None       -> Hashtbl.remove  t.states  key
    | Some state -> Hashtbl.set t.states ~key ~data:state
  ;;

  let enqueue t ~key ?tag f =
    Deferred.create (fun ivar ->
      (* when job is called, [f] is invoked immediately, there shall be no deferred in
         between *)
      let run state_opt =
        Monitor.try_with ~run:`Now (fun () -> f state_opt) >>| Ivar.fill ivar
      in
      let job = { Job. tag = Tag.User_job tag; run } in
      match Hashtbl.find t.jobs key with
      | Some queue -> Queue.enqueue queue job
      | None ->
        let queue = Queue.create () in
        Queue.enqueue queue job;
        Hashtbl.set t.jobs ~key ~data:queue;
        (* never start a job in the same async job *)
        upon Deferred.unit (fun () ->
          run_jobs_until_none_remain t ~key queue);
    )
    >>| function
    | Error exn -> raise (Monitor.extract_exn exn)
    | Ok res -> res
  ;;

  let find_state t key = Hashtbl.find t.states key

  let num_unfinished_jobs t key =
    match Hashtbl.find t.jobs key with
    | None -> 0
    | Some queue -> Queue.length queue
  ;;

  let mem t key = Hashtbl.mem t.states key || Hashtbl.mem t.jobs key

  let fold t ~init ~f =
    let all_keys =
      Key.Hash_set.create ~size:(Hashtbl.length t.jobs + Hashtbl.length t.states) ()
    in
    Hashtbl.iteri t.jobs   ~f:(fun ~key ~data:_ -> Hash_set.add all_keys key);
    Hashtbl.iteri t.states ~f:(fun ~key ~data:_ -> Hash_set.add all_keys key);
    Hash_set.fold all_keys ~init ~f:(fun acc key ->
      f acc ~key (Hashtbl.find t.states key))
  ;;

  let prior_jobs_done t =
    Hashtbl.fold t.jobs ~init:[] ~f:(fun ~key:_ ~data:queue acc ->
      let this_key_done =
        Deferred.create (fun ivar ->
          Queue.enqueue queue
            { tag = Tag.Prior_jobs_done
            ; run = (fun _ -> Ivar.fill ivar (); Deferred.unit)
            })
      in
      this_key_done :: acc)
    |> Deferred.all_unit
  ;;
end

let%test_module _ =
  (module struct
    module T = Make(Int)

    let (=) = Poly.(=)

    exception Abort of int

    let%test_unit _ =
      (* don't run a job immediately *)
      Thread_safe.block_on_async_exn (fun () ->
        let t = T.create () in
        let i = ref 0 in
        let res = T.enqueue t ~key:0 (fun _ -> incr i; Deferred.unit) in
        assert (!i = 0);
        res >>| fun () ->
        assert (!i = 1)
      )

    let%test_unit _ =
      (* no deferred between finding state and running the job *)
      (* let [enqueue] function, when [Monitor.try_with] did not take [~run:`Now], then this
         unit test failed to pass *)
      Thread_safe.block_on_async_exn (fun () ->
        let t = T.create () in
        let i = ref `init in
        debug_on_find_state := (fun () ->
          Deferred.unit >>> fun () -> i := `deferred_determined
        );
        T.enqueue t ~key:0 (fun _ ->
          [%test_eq: [`init | `deferred_determined]] !i `init;
          Deferred.unit
        )
        >>| fun () ->
        debug_on_find_state := ignore
      )

    let%test_unit _ =
      Thread_safe.block_on_async_exn (fun () ->
        let t = T.create () in
        let num_keys = 100 in
        let keys = List.init num_keys ~f:Fn.id in
        let started_jobs = Queue.create () in
        let enqueue key x =
          Monitor.try_with (fun () ->
            T.enqueue t ~key (fun state ->
              let state =
                match state with
                | None -> [x]
                | Some xs -> x::xs
              in
              T.set_state t ~key (Some state);
              Queue.enqueue started_jobs key;
              Clock.after (sec 0.01) >>| fun () ->
              (* check continue on error *)
              raise (Abort key)
            )
          )
          >>| function
          | Error exn ->
            begin match Monitor.extract_exn exn with
            | (Abort i) when i = key -> ()
            | _ -> assert false
            end
          | _ -> assert false
        in
        Deferred.List.iter keys ~how:`Parallel ~f:(fun key ->
          Deferred.List.iter ['a'; 'b'; 'c' ] ~how:`Parallel ~f:(enqueue key)
        )
        >>| fun () ->
        List.iter keys ~f:(fun key ->
          (* check [find_state] *)
          (* check jobs are sequentialized for the same key *)
          assert (T.find_state t key = Some ['c'; 'b'; 'a'])
        );
        (* check jobs on different keys can run concurrently *)
        let started_jobs_in_batched =
          List.chunks_of ~length:num_keys (Queue.to_list started_jobs)
        in
        List.iter started_jobs_in_batched ~f:(fun l ->
          assert (List.sort l ~compare:Int.compare = keys)
        );
      )
    ;;

    let%test_unit _ =
      (* Test [num_unfinished_jobs] *)
      Thread_safe.block_on_async_exn (fun () ->
        let t = T.create () in
        assert (T.num_unfinished_jobs t 0 = 0);
        let job1 =
          T.enqueue t ~key:0 (fun _ ->
            assert (T.num_unfinished_jobs t 0 = 3); Deferred.unit)
        in
        let job2 =
          T.enqueue t ~key:0 (fun _ ->
            assert (T.num_unfinished_jobs t 0 = 2); Deferred.unit)
        in
        let job3 =
          T.enqueue t ~key:0 (fun _ ->
            assert (T.num_unfinished_jobs t 0 = 1); Deferred.unit)
        in
        assert (T.num_unfinished_jobs t 0 = 3);
        Deferred.all_unit [job1; job2; job3] >>| fun () ->
        assert (T.num_unfinished_jobs t 0 = 0)
      )

    let%test_unit _ =
      (* Test [mem] *)
      Thread_safe.block_on_async_exn (fun () ->
        let t = T.create () in
        (* empty *)
        assert (T.mem t 0 = false);
        let job = T.enqueue t ~key:0 (fun _ -> Deferred.unit) in
        (* with job *)
        assert (T.mem t 0);
        job >>= fun () ->
        (* without job *)
        assert (T.mem t 0 = false);
        (* with state *)
        T.set_state t ~key:0 (Some 'a');
        assert (T.mem t 0);
        T.set_state t ~key:0 None;
        (* without state *)
        assert (T.mem t 0 = false);
        let job =
          T.set_state t ~key:0 (Some 'a');
          T.enqueue t ~key:0 (fun _ -> Deferred.unit)
        in
        (* with job and state *)
        assert (T.mem t 0);
        job >>| fun () ->
        (* without job but with state *)
        assert (T.mem t 0)
      )
    ;;

    let%test_unit _ = (* enqueueing within a job doesn't lead to monitor nesting *)
      Thread_safe.block_on_async_exn (fun () ->
        let t = T.create () in
        let rec loop n =
          if n = 0
          then Deferred.unit
          else
            T.enqueue t ~key:13 (fun _ ->
              assert (Monitor.depth (Monitor.current ()) < 5);
              don't_wait_for (loop (n - 1));
              Deferred.unit)
        in
        loop 100)
    ;;

    let%test_unit _ = (* [flushed] is determined after all current jobs are finished *)
      Thread_safe.block_on_async_exn (fun () ->
        let t = T.create () in
        let phase1_finished = Ivar.create () in
        let phase2_finished = Ivar.create () in
        let num_flushed = 2 in
        let num_not_flushed = 2 in
        for i = 1 to num_flushed do
          don't_wait_for (T.enqueue t ~key:i (fun _ -> Ivar.read phase1_finished));
        done;
        let phase1_flushed = T.prior_jobs_done t in
        for i = 1 to num_flushed + num_not_flushed do
          don't_wait_for (T.enqueue t ~key:i (fun _ -> Ivar.read phase2_finished));
        done;
        for i = 1 to num_flushed do
          (* two jobs we enqueued, and one job [flush] added *)
          assert (T.num_unfinished_jobs t i = 3)
        done;
        for i = num_flushed + 1 to num_flushed + num_not_flushed do
          assert (T.num_unfinished_jobs t i = 1)
        done;
        Ivar.fill phase1_finished ();
        phase1_flushed
        >>= fun () ->
        for i = 1 to num_flushed + num_not_flushed do
          assert (T.num_unfinished_jobs t i = 1)
        done;
        Ivar.fill phase2_finished ();
        T.prior_jobs_done t
        >>| fun () ->
        for i = 1 to num_flushed + num_not_flushed do
          assert (T.num_unfinished_jobs t i = 0)
        done;
      )
    ;;
  end)